Re: Add memory_limit_hits to pg_stat_replication_slots

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add memory_limit_hits to pg_stat_replication_slots
Date: 2025-10-03 03:39:56
Message-ID: aN9FjFgroerXZcW8@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Oct 02, 2025 at 04:39:40PM -0700, Masahiko Sawada wrote:
> On Thu, Sep 25, 2025 at 10:26 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> Agreed. It would be better to show a raw statistic so that users can
> use the number as they want.
>
> I've made a small comment change

Thanks!

Comparing v5 and v6:

- /* Number of times logical_decoding_work_mem has been reached */
+ /* Number of times the logical_decoding_work_mem limit has been reached */

LGTM.

> and added the commit message to the
> v5 patch. I'm going to push the attached patch barring any objection
> or review comments.

The commit message LGTM.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-10-03 05:12:29 Re: GB18030-2022 Support in PostgreSQL
Previous Message Richard Guo 2025-10-03 03:14:40 Re: Eager aggregation, take 3