| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, mert(at)futo(dot)org, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist |
| Date: | 2025-07-24 16:30:49 |
| Message-ID: | aIJfucaqjZ3gh-xj@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jul 22, 2025 at 04:27:24AM +0200, Laurenz Albe wrote:
> I tested your patch, and it works as expected for
Thanks for reviewing.
> There is still one piece missing in my opinion:
>
> ALTER SYSTEM RESET testext.swap_limit;
> ERROR: invalid configuration parameter name "testext.swap_limit"
> DETAIL: "testext" is a reserved prefix.
>
> I think that this case should work like the others.
Good catch. This should be fixed in v3.
> I'd like to see regression tests for this, but I am not sure how
> to best devise them.
> One idea would be to stick them into the regression tests of some
> contrib module, even though it is not the perfect place.
Added in v3.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Allow-resetting-unknown-custom-GUCs-with-reserved.patch | text/plain | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-24 17:33:36 | Re: BUG #18997: Two equivalent queries return different results |
| Previous Message | Fujii Masao | 2025-07-24 15:55:26 | Re: Unexpected Standby Shutdown on sync_replication_slots change |