Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org, maralist86(at)mail(dot)ru
Subject: Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL
Date: 2025-07-01 06:49:09
Message-ID: aGOE5RrFODHJldxo@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Jun 09, 2025 at 07:27:56AM +0900, Michael Paquier wrote:
> I've made similar choices in the past around the same time in the
> release cycle not backpatching stuff that was an issue in backbranches
> still minimal enough to not have to worry about, like 84e4570da923
> (there are a few others).

While doing a secondary review of all that, I have noticed one call to
pg_xml_done() missing at the end of xpath_string(). The rest was
pretty clean. I have split the changes into two parts for clarity,
and applied each one of them separately: one for xml.c and one for the
contrib module xml2/.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Shlok Kyal 2025-07-01 19:41:32 Re: BUG #18897: Logical replication conflict after using pg_createsubscriber under heavy load
Previous Message jian he 2025-07-01 03:25:20 Re: BUG #18970: Atempt to alter type of table column used in row type with check leads to assertion failure