Re: [PATCH] Use binaryheap_* macro where appropriate

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Use binaryheap_* macro where appropriate
Date: 2025-06-26 20:16:35
Message-ID: aF2qowqbG1FW8lgF@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 26, 2025 at 01:18:10PM +0300, Aleksander Alekseev wrote:
> I noticed several places where we access `struct binaryheap` directly
> instead of using binaryheap_size() and binaryheap_empty() which
> doesn't seem right. Here is the patch.

Seems reasonable. I'll plan on committing this once v19 is open for
business.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-06-26 20:30:57 Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()
Previous Message Melanie Plageman 2025-06-26 19:56:07 Re: Fix some inconsistencies with open-coded visibilitymap_set() callers