| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add function for creating/attaching hash table in DSM registry |
| Date: | 2025-06-10 17:25:49 |
| Message-ID: | aEhqnVW2bjKf6gp3@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 10, 2025 at 07:47:02PM +0300, Florents Tselai wrote:
> Love this new API.
Thanks!
> a minor typo here
> + * current backend. This function gurantees that only one backend
Fixed.
> Since you made the first step towards decoupling DSMR_NAME_LEN from NAMEDATALEN;
> is it worth considering increasing this to 128 maybe?
>
> I´ve used DSMR extensively for namespacing keys etc, and I´ve come close to 50-60 chars at times.
>
> I´m not too fixed on that though.
Seems fine to me.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-simplify-creating-hash-table-in-dsm-registry.patch | text/plain | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-06-10 17:27:34 | Re: pg_restore causing ENOSPACE on the WAL partition. Fundamental issue? |
| Previous Message | Álvaro Herrera | 2025-06-10 17:25:27 | Re: queryId constant squashing does not support prepared statements |