| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add function for creating/attaching hash table in DSM registry |
| Date: | 2025-06-10 15:38:29 |
| Message-ID: | aEhRdaENQG8tVKcb@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 09, 2025 at 07:14:28PM -0500, Sami Imseih wrote:
> Going back to the original point, DSMRegistryHash and DSMRegistryHash
> are built-in, and those names are well-defined and actually refer to
> waits related to the mechanism of registering a DSA or a HASH.
> I think it will be odd to append "_dsh", but we should at minimum add
> a comment in the GetNamedDSMHash explaining this.
This should be addressed in v3.
I'm not quite following your uneasiness with the tranche names. For the
dshash table, we'll need a tranche for the DSA and one for the hash table,
so presumably any wait events for those locks should be named accordingly,
right?
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-simplify-creating-hash-table-in-dsm-registry.patch | text/plain | 10.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrice Chapuis | 2025-06-10 15:46:33 | failover logical replication slots |
| Previous Message | Peter Eisentraut | 2025-06-10 15:32:01 | Re: Remaining dependency on setlocale() |