Re: Minimal logical decoding on standbys

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Subject: Re: Minimal logical decoding on standbys
Date: 2023-04-05 07:59:24
Message-ID: a7ed8d42-4a0e-788f-927e-2294bc861f85@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 4/4/23 7:53 PM, Andres Freund wrote:
> Hi,
>
> On 2023-04-04 18:54:33 +0200, Drouvot, Bertrand wrote:
>> if (check_on_xid)
>> {
>> if (terminating)
>> appendStringInfo(&err_msg, _("terminating process %d to release replication slot \"%s\" because it conflicts with recovery"),
>> pid,
>> NameStr(slotname));
>
> FWIW, I would just use exactly the same error message as today here.
>
> errmsg("terminating process %d to release replication slot \"%s\"",
> active_pid, NameStr(slotname)),
>
> This is accurate for both the existing and the new case. Then there's no need
> to put that string into a stringinfo either.
>

Right, thanks! Did it that way in V60 attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v60-0006-Doc-changes-describing-details-about-logical-dec.patch text/plain 2.2 KB
v60-0005-New-TAP-test-for-logical-decoding-on-standby.patch text/plain 32.9 KB
v60-0004-For-cascading-replication-wake-up-physical-walse.patch text/plain 9.0 KB
v60-0003-Allow-logical-decoding-on-standby.patch text/plain 12.0 KB
v60-0002-Arrange-for-a-new-pg_stat_database_conflicts-and.patch text/plain 10.4 KB
v60-0001-Handle-logical-slot-conflicts-on-standby.patch text/plain 28.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-04-05 08:01:22 Re: Minimal logical decoding on standbys
Previous Message Daniel Gustafsson 2023-04-05 07:49:31 Re: Commitfest 2023-03 starting tomorrow!