WIP: raise error when submitting invalid ALTER SYSTEM command

From: "Jordan Deitch" <jd(at)rsa(dot)pub>
To: pgsql-hackers(at)postgresql(dot)org
Subject: WIP: raise error when submitting invalid ALTER SYSTEM command
Date: 2019-10-09 03:12:17
Message-ID: a6ad7661-9b44-4e9c-923b-be1b25315023@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

ALTER SYSTEM currently does not raise error upon invalid entry. Take for example:

alter system set superuser_reserved_connections = 10;
> ALTER SYSTEM
alter system set max_connections = 5;
> ALTER SYSTEM

The database will now fail to restart without manual intervention by way of editing the autoconf file (which says "# Do not edit this file manually!" on its first line).

The attached WIP patch is intended to raise an error on invalid ALTER SYSTEM commands before being written out to the filesystem. Hopefully this behavior is more intuitive.

Thanks
--
Jordan Deitch
https://id.rsa.pub/

Attachment Content-Type Size
001-alter-system-raise-error-on-invalid-combination.patch application/octet-stream 6.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-10-09 04:51:47 Re: maintenance_work_mem used by Vacuum
Previous Message Bruce Momjian 2019-10-09 02:17:29 Re: format of pg_upgrade loadable_libraries warning