| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mi Tar <mmitar(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: port of INSTALL file generation to XSLT |
| Date: | 2019-01-13 09:54:18 |
| Message-ID: | a4053e52-708f-e648-0af9-e10ad4cff84f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/01/2019 22:05, Tom Lane wrote:
>> 2. If there's no pandoc, this coding silently produces a zero-size
>> INSTALL file. I do not find that acceptable.
>
> Seems like it might be sufficient for the rule to be
>
> $(PANDOC) $< -t plain > $(at)(dot)tmp
> $(ICONV) -f utf8 -t us-ascii//TRANSLIT < $(at)(dot)tmp > $@
> rm -f $(at)(dot)tmp
Fixed. (We use the same pattern for the dtrace invocation.)
I suppose the same issue would have existed with the previous rule using
lynx, but no one has ever run into it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2019-01-13 11:39:16 | Re: O_DIRECT for relations and SLRUs (Prototype) |
| Previous Message | Peter Eisentraut | 2019-01-13 09:43:28 | Re: [HACKERS] generated columns |