Re: executor relation handling

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: jesper(dot)pedersen(at)redhat(dot)com, Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: executor relation handling
Date: 2018-09-14 05:36:38
Message-ID: a20151ff-9d3b-bec8-8c64-5336676cfda3@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Thanks again, Jesper.

On 2018/09/13 20:27, Jesper Pedersen wrote:
> Hi Amit,
>
> On 9/13/18 12:58 AM, Amit Langote wrote:
>> Attached updated patches.
>>
>> Beside the issue that caused eval-plan-qual isolation test to crash, I
>> also spotted and fixed an oversight in the 0002 patch which would lead to
>> EState.es_output_cid being set to wrong value and causing unexpected error
>> during tuple locking as result of that.
>>
>
> Thanks for the update.
>
> However, the subscription TAP test
> (src/test/subscription/t/001_rep_changes.pl) is still failing.
>
> CFBot has the same log
>
>  https://travis-ci.org/postgresql-cfbot/postgresql/builds/427999969
>
> as locally.

My bad. I missed that logical replication code depends on the affected
executor code.

Fixed patches attached.

Thanks,
Amit

Attachment Content-Type Size
v5-0001-Don-t-lock-range-table-relations-in-the-executor.patch text/plain 41.3 KB
v5-0002-Remove-useless-fields-from-planner-nodes.patch text/plain 37.4 KB
v5-0003-Prune-PlanRowMark-of-relations-that-are-pruned-fr.patch text/plain 2.4 KB
v5-0004-Revise-executor-range-table-relation-opening-clos.patch text/plain 37.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-09-14 06:08:22 Re: hot_standby_feedback vs excludeVacuum and snapshots
Previous Message Michael Paquier 2018-09-14 04:46:24 Re: Cache lookup errors with functions manipulation object addresses