| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add errdetail() with PID and UID about source of termination signal |
| Date: | 2026-04-07 16:49:19 |
| Message-ID: | a076e20d-fc56-4b5d-aa47-a52b4e7a5061@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-04-07 Tu 10:55 AM, Andres Freund wrote:
>
> This seems completely wrong from a layering POV. The wrapper has no business
> whatsoever to know that how SIGTERM is interpreted and thus no business
> setting variables like ProcDieSenderPid.
>
> Pretty sure have some sigterm handlers that shouldn't set ProcDieSenderPid.
>
>
> A more correct answer here would be to forward information about the sender of
> a signal to the signal handlers and let them interpret the information if
> available.
>
OK, fair points. Does the attached meet your concerns?
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| errdetail-pid-fix.patch | text/x-patch | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-04-07 17:00:14 | Re: dshash_find_or_insert vs. OOM |
| Previous Message | Sami Imseih | 2026-04-07 16:35:22 | Re: Refactor query normalization into core query jumbling |