| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta(dot)malik(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description |
| Date: | 2024-10-31 17:35:20 |
| Message-ID: | ZyO_2NWC5MyWq0bH@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 24, 2024 at 08:32:54AM +1100, Peter Smith wrote:
> Hi. Here are a couple of minor comments.
>
> 1.
> + The time slot synchronization (see <xref
> + linkend="logicaldecoding-replication-slots-synchronization"/>)
> + was most recently stopped.
>
> /The time slot/The time when slot/
>
> ~~~
>
> 2.
> - /* The time since the slot has become inactive */
> + /* The time slot sychronized was stopped. */
>
>
> Maybe just make this comment the same as the sentence used in the docs:
> - e.g. add "when"; fix, typo "sychronized", etc.
>
>
> /The time slot sychronized was stopped./The time when slot
> synchronization was most recently stopped./
Yes, all good suggestions, updated patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
| Attachment | Content-Type | Size |
|---|---|---|
| inactive.diff | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-10-31 17:41:57 | Re: "command cannot affect row a second time" in INSERT ... ON CONFLICT |
| Previous Message | Andrey M. Borodin | 2024-10-31 17:32:42 | Re: MultiXact\SLRU buffers configuration |