| From: | Michael Paquier <michael(at)paquier(dot)xyz> | 
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Subject: | Some refactoring for fixed-numbered stats template in injection_points | 
| Date: | 2024-08-19 00:33:38 | 
| Message-ID: | ZsKS4oyZZxMDOi0z@paquier.xyz | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Hi all,
While reading again the code of injection_stats_fixed.c that holds the
template for fixed-numbered pgstats, I got an idea to make the code a
bit more elegant.  Rather than using a single routine to increment the
counters, we could use a series of routines with its internals hidden
in a macro like in pgstatfuncs.c.
The point of a template is to be as elegant as possible, and this
is arguably a better style, still this comes down to personal taste
perhaps.  Please feel free to comment about the attached.
Thanks,
--
Michael
| Attachment | Content-Type | Size | 
|---|---|---|
| 0001-injection_points-Make-template-for-fixed-numbered-st.patch | text/x-diff | 5.4 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-08-19 00:51:12 | Re: Cirrus CI for macOS branches 16 and 15 broken | 
| Previous Message | Michael Paquier | 2024-08-19 00:09:34 | Re: Injection Points remaining stats |