PgStat_KindInfo.named_on_disk not required in shared stats

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: PgStat_KindInfo.named_on_disk not required in shared stats
Date: 2024-06-07 05:07:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,
(Relevant folks in CC.)

While hacking on the area of pgstat_*.c, I have noticed the existence
of named_on_disk in PgStat_KindInfo, that is here to track the fact
that replication slots are a particular case in the PgStat_HashKey for
the dshash table of the stats because this kind of stats requires a
mapping between the replication slot name and the hash key.

As far as I can see, this field is not required and is used nowhere,
because the code relies on the existence of the to_serialized_name and
from_serialized_name callbacks to do the mapping.

Wouldn't it make sense to remove it? This field is defined since
5891c7a8ed8f that introduced the shmem stats, and has never been used

This frees an extra bit in PgStat_KindInfo, which is going to help me
a bit with what I'm doing with this area of the code while keeping the
structure size the same.


Attachment Content-Type Size
0001-Remove-PgStat_KindInfo.named_on_disk.patch text/x-diff 2.0 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-06-07 05:14:24 Re: cannot drop intarray extension
Previous Message Dilip Kumar 2024-06-07 04:36:27 Re: How about using dirty snapshots to locate dependent objects?