Re: Support a wildcard in backtrace_functions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Support a wildcard in backtrace_functions
Date: 2024-04-18 07:02:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Apr 12, 2024 at 09:36:36AM +0900, Michael Paquier wrote:
> log_backtrace speaks a bit more to me as a name for this stuff because
> it logs a backtrace. Now, there is consistency on HEAD as well
> because these GUCs are all prefixed with "backtrace_". Would
> something like a backtrace_mode where we have an enum rather than a
> boolean be better? One thing would be to redesign the existing GUC as
> having two values on HEAD as of:
> - "none", to log nothing.
> - "internal", to log backtraces for internal errors.
> Then this could be extended with more modes, to discuss in future
> releases as new features.

As this is an open item, let's move on here.

Attached is a proposal of patch for this open item, switching
backtrace_on_internal_error to backtrace_mode with two values:
- "none", to log no backtraces.
- "internal", to log backtraces for internal errors.

The rest of the proposals had better happen as a v18 discussion, where
extending this GUC is a benefit.

Attachment Content-Type Size
0001-backtrace_on_internal_error-backtrace_mode.patch text/x-diff 6.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-04-18 07:05:14 Re: promotion related handling in pg_sync_replication_slots()
Previous Message Heikki Linnakangas 2024-04-18 07:00:59 Re: plenty code is confused about function level static