| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Spurious pgstat_drop_replslot() call |
| Date: | 2024-03-08 10:19:11 |
| Message-ID: | ZermH08Eq6YydHpO@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
Please find attached a tiny patch to remove a $SUBJECT.
Indeed, it does not seem appropriate to remove stats during slot invalidation as
one could still be interested to look at them.
This spurious call has been introduced in be87200efd. I think that initially we
designed to drop slots when a recovery conflict occurred during logical decoding
on a standby. But we changed our mind to invalidate such a slot instead.
The spurious call is probably due to the initial design but has not been removed.
I don't think it's worth to add a test but can do if one feel the need.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-spurious-pgstat_drop_replslot-call.patch | text/x-diff | 944 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-03-08 10:20:39 | Re: a wrong index choose when statistics is out of date |
| Previous Message | Stephen Frost | 2024-03-08 10:17:56 | Re: Proposal to add page headers to SLRU pages |