Re: Adding facility for injection points (or probe points?) for more advanced tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adding facility for injection points (or probe points?) for more advanced tests
Date: 2023-12-12 10:44:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Dec 12, 2023 at 10:27:09AM +0530, Dilip Kumar wrote:
> Oops, I only included the code changes where I am adding injection
> points and some comments to verify that, but missed the actual test
> file. Attaching it here.

I see. Interesting that this requires persistent connections to work.
That's something I've found clunky to rely on when the scenarios a
test needs to deal with are rather complex. That's an area that could
be made easier to use outside of this patch.. Something got proposed
by Andrew Dunstan to make the libpq routines usable through a perl
module, for example.

> Note: I think the latest patches are conflicting with the head, can you rebase?

Indeed, as per the recent manipulations in ipci.c for the shmem
initialization areas. Here goes a v6.

Attachment Content-Type Size
v6-0001-Add-backend-facility-for-injection-points.patch text/plain 22.1 KB
v6-0002-Add-test-module-test_injection_points.patch text/plain 14.5 KB
v6-0003-Add-regression-test-to-show-snapbuild-consistency.patch text/plain 4.2 KB
v6-0004-Add-basic-test-for-promotion-and-restart-race-con.patch text/plain 10.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jehan-Guillaume de Rorthais 2023-12-12 10:52:46 Re: Sorting regression of text function result since commit 586b98fdf1aae
Previous Message Junwang Zhao 2023-12-12 10:40:15 [meson] expose buildtype debug/optimization info to pg_config