| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Should logtape.c blocks be of type long? |
| Date: | 2023-11-17 02:26:58 |
| Message-ID: | ZVbPcvSVJsl4fNvt@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 16, 2023 at 03:03:46PM +0100, Heikki Linnakangas wrote:
> BufFileTellBlock should be adjusted too. Or removed altogether; it's been
> commented out since year 2000. Other than that, looks good to me.
Yes, I recall wondering about what to do on this one so I just let it
be when updating the last version of the patch as we have many
NOT_USED stuff in the core code. After 23 years being around for no
purpose, I have just applied a patch to remove it for the sake of this
change, then applied the main change.
Thanks for double-checking, Heikki!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-11-17 03:25:11 | Re: Wrong results with grouping sets |
| Previous Message | Richard Guo | 2023-11-17 02:09:10 | Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500 |