Re: crashes if some extensions were loaded.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: crashes if some extensions were loaded.
Date: 2023-11-01 22:53:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote:
> Found that src/test/modules/test_misc/t/ will crash if an extension
> that adds own GUCs was loaded into memory.
> So it is now impossible to run a check-world with loaded extension libraries.

Right. That's annoying, so let's fix it.

> --- a/src/test/modules/test_misc/t/
> +++ b/src/test/modules/test_misc/t/
> @@ -19,7 +19,7 @@ my $all_params = $node->safe_psql(
> "SELECT name
> FROM pg_settings
> WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
> - name <> 'config_file'
> + name <> 'config_file' AND name NOT LIKE '%.%'
> ORDER BY 1");

Wouldn't it be better to add a qual as of "category <> 'Customized
Options'"? That's something arbitrarily assigned for all custom GUCs
and we are sure that none of them will exist in
postgresql.conf.sample. There's also no guarantee that out-of-core
custom GUCs will include a dot in their name (even if I know that
maintainers close to the community adopt this convention and are
rather careful about that).

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-11-01 22:54:49 Re: Commitfest manager November 2023
Previous Message Michael Paquier 2023-11-01 22:35:22 Re: Typo in "43.9.1. Reporting Errors and Messages"?