Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ryoga Yoshida <bt23yoshidar(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly
Date: 2023-09-26 00:33:23
Message-ID: ZRIm06ISiYWq4ivF@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 25, 2023 at 02:49:50PM +0900, Ryoga Yoshida wrote:
> On 2023-09-25 14:38, Michael Paquier wrote:
>> Another idea would be to do like in pgstat.c by adding the following
>> line, then use "nowait" to call each sub-function:
>> nowait = !force;
>> pgstat_flush_wal(nowait);
>> pgstat_flush_io(nowait);
>
> That's very clear and I think it's good.

Done this way down to 15, then, with more comment polishing.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-09-26 01:06:36 Re: Add 'worker_type' to pg_stat_subscription
Previous Message Michael Paquier 2023-09-25 23:18:01 Re: Doc: vcregress .bat commands list lacks "taptest"