Re: BUG #18057: unaccent removes intentional spaces

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: martin(at)schlossarek(dot)me, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18057: unaccent removes intentional spaces
Date: 2023-08-21 07:14:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Sun, Aug 20, 2023 at 09:20:48AM +0900, Michael Paquier wrote:
> Apologies for the confusion. I was thinking to also escape \ in
> quoted strings. Your suggestion to use a second double-quote for the
> escaping is fine by me. """" feels a bit ugly-ish in the rules file,
> for sure, but that does not look like a huge issue to me as long as
> the python script generates consistent contents ;)

Please find attached a patch to achieve that. This includes tweaks
for the python script to update unaccent.rules, docs about the rules
for the quotes and tests.

The patch also includes a custom rule file that I have used to stress
more the parsing logic, but I intend to remove it in the final version
of the patch (and it fails with meson). It would be possible to have
a TAP test that sneaks a custom rule file in the installation tree,
but that's not worth the extra cycles IMO.

What do you think?

Attachment Content-Type Size
0001-unaccent-Add-support-for-quoted-translated-character.patch text/x-diff 11.5 KB

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2023-08-21 12:33:37 Re: BUG #17994: Invalidating relcache corrupts tupDesc inside ExecEvalFieldStoreDeForm()
Previous Message Michael Paquier 2023-08-20 23:32:39 Re: BUG #17928: Standby fails to decode WAL on termination of primary