Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jchampion(at)timescale(dot)com>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: 2023-07-20 23:53:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Thu, Jul 20, 2023 at 12:36:52PM +0200, Daniel Gustafsson wrote:
> On 20 Jul 2023, at 09:47, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Hmm. Are you sure that this is correct for pg_rewind? This should
>> work when using a local source with --source-pgdata, but under a
>> remote source with --source-pgdata, I get the impression that we'd
>> still copy a .DS_store into the target's data folder.
> Ah, good point. The updated patch should work for both by moving the check
> into the filemap.

Sounds OK to me to do that in the filemap. The checksum and base
backup parts look OK as well. Thanks for the quick update!

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Masahiko Sawada 2023-07-21 08:01:11 Re: BUG #18031: Segmentation fault after deadlock within VACUUM's parallel worker
Previous Message Andres Martin del Campo Campos 2023-07-20 17:16:38 Re: BUG #18027: Logical replication taking forever