Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Evan Jones <evan(dot)jones(at)datadoghq(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date: 2023-06-18 08:32:15
Message-ID: ZI7BD6jTsn4vdCxe@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 18, 2023 at 10:50:16AM +0900, Michael Paquier wrote:
> The difference between scanner_isspace() and array_isspace() is that
> the former matches with what scan.l stores as rules for whitespace
> characters, but the latter works on values. For hstore, we want the
> latter, with something that works on values. To keep the change
> locale to hstore, I think that we should just introduce an
> hstore_isspace() which is a copy of array_isspace. That's a
> duplication, sure, but I think that we may want to think harder about
> \v in the flex scanner, and that's just a few extra lines for
> something that has not changed in 13 years for arrays. That's also
> easier to think about for stable branches. If you can send a patch,
> that helps a lot, for sure!

At the end, no need to do that. I have been able to hack the
attached, that shows the difference of treatment for \v when running
in macOS. Evan, what do you think?
--
Michael

Attachment Content-Type Size
0001-More-fixes-for-hstore-and-locales.patch text/x-diff 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema 2023-06-18 11:03:57 Re: Deleting prepared statements from libpq.
Previous Message Michael Paquier 2023-06-18 01:50:16 Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific