| From: | Dongpo Liu <poe(dot)liu(at)pm(dot)me> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Remove unused include from analyze.c |
| Date: | 2026-07-05 13:27:20 |
| Message-ID: | ZFHOybslVhRiAa9bF3UFrDVR3kjhG4wbCjzv_CEpceduWnOKdbq7xqBNXvzCsSqpAEoZeLFyW0ibbImVEdZLVUcj_nsS4uILbO-IRUSKzJE=@pm.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
While reading the ANALYZE code, I noticed that
src/backend/commands/analyze.c still includes storage/procarray.h,
but nothing in the file uses it anymore.
Commit 284925508ae removed the call to
GetOldestNonRemovableTransactionId() from acquire_sample_rows(), which
was the last reference to anything declared in that header. The #include
was left behind.
The attached patch removes it. The file compiles cleanly without it,
and I verified that no other symbol from procarray.h is referenced there.
Regards,
Dongpo Liu
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-unnecessary-include-storage-procarray.h.patch | application/octet-stream | 954 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sehrope Sarkuni | 2026-07-05 15:13:58 | Re: inconsistent jsonb 'null' conversions |
| Previous Message | Pavel Stehule | 2026-07-05 12:58:27 | inconsistent jsonb 'null' conversions |