|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>|
|Cc:||Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: pg_recvlogical prints bogus error when interrupted|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Thu, Apr 27, 2023 at 11:24:52AM +0530, Bharath Rupireddy wrote:
> IMO, +1 for HEAD/PG16 and +0.5 for backpatching as it may not be so
> critical to backpatch all the way down. What may happen without this
> patch is that the output file isn't fsync-ed upon SIGINT/SIGTERM.
> Well, is it a critical issue on production servers?
It is also true that it's been this way for years with basically
nobody complaining outside this thread. So there is also an argument
about leaving v16 out of the picture, and do that only in 17~ to avoid
playing with the branch stability more than necessary? I see 7 open
items as of today, and there are TAP tests linked to pg_recvlogical.
That should be OK, because none of these tests rely on specific
signals, but the buildfarm has some weird setups, as well..
|Next Message||Drouvot, Bertrand||2023-04-27 07:35:03||Re: Add two missing tests in 035_standby_logical_decoding.pl|
|Previous Message||Michael Paquier||2023-04-27 06:13:42||Re: Autogenerate some wait events code and documentation|