| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix fseek() detection of unseekable files on WIN32 |
| Date: | 2023-03-22 00:12:36 |
| Message-ID: | ZBpH9GHRHfph958p@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 20, 2023 at 07:06:22AM +0900, Michael Paquier wrote:
> Not sure about this one. I have considered it and dirmod.c includes
> also bits for cygwin, while being aimed for higher-level routines like
> rename(), unlink() or symlink(). This patch is only for WIN32, and
> aimed for common parts in win32*.c code, so a separate file seemed a
> bit cleaner to me at the end.
By the way, do you think that we could be able to get a TAP test for
that? It does not seem that it needs to be that complicated, as long
as we use a pg_dump command that pipes its output to a pg_restore
command launched by system()?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-03-22 00:52:52 | Re: Track IO times in pg_stat_io |
| Previous Message | Michael Paquier | 2023-03-21 23:59:19 | Re: allow_in_place_tablespaces vs. pg_basebackup |