Re: [BUG] Crash of logical replica with trigger.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: [BUG] Crash of logical replica with trigger.
Date: 2022-10-07 08:40:04
Message-ID: Yz/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Fri, Oct 07, 2022 at 05:19:46PM +0900, Masahiko Sawada wrote:
> I realized that this problem is also reported in -hackers and there is
> some discussion there[1]. The patch I proposed seems to be the same as
> the patch Anton A. Melnikov proposed, but Tom does not like it.

This patch was listed in the CF which is why I have begun poking at

Anyway, I have the same opinion, and the first thing I was looking at
are other code paths similar to the one patched here where we expect a
portal to be always active :)

Your patch switches a procedure path where we have assumed for years
that a portal would be active in its error handling. This could hide
problems in the future if for some reason this API begins to get used
in the context where a portal is not active, so logical workers are
IMO doing the wrong thing for the commands they are executing.

Let's move the discussion to the other thread, thanks for the

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Frank van Vugt 2022-10-07 11:42:45 Re: v15rc2(/v15rc1/v15b4) shadowbuild fails when using src from symlink
Previous Message Masahiko Sawada 2022-10-07 08:19:46 Re: [BUG] Crash of logical replica with trigger.