|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||"Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>|
|Cc:||Jacob Champion <jchampion(at)timescale(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: SYSTEM_USER reserved word implementation|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Fri, Aug 26, 2022 at 10:02:26AM +0900, Michael Paquier wrote:
> FWIW, I was also wondering about the need for all this initialization
> stanza and the extra SystemUser in TopMemoryContext. Now that we have
> MyClientConnectionInfo, I was thinking to just build the string in the
> SQL function as that's the only code path that needs to know about
> it. True that this approach saves some extra palloc() calls each time
> the function is called.
At the end, fine by me to keep this approach as that's more
consistent. I have reviewed the patch, and a few things caught my
- I think that we'd better switch InitializeSystemUser() to have two
const char * as arguments for authn_id and an auth_method, so as there
is no need to use tweaks with UserAuth or ClientConnectionInfo in
miscadmin.h to bypass an inclusion of libpq-be.h or hba.h.
- The OID of the new function should be in the range 8000-9999, as
taught by unused_oids.
- Environments where the code is built without krb5 support would skip
the test where SYSTEM_USER should be not NULL when authenticated, so I
have added a test for that with MD5 in src/test/authentication/.
- Docs have been reworded, and I have applied an indentation.
- No need to use 200k rows in the table used to force the parallel
scan, as long as the costs are set.
It is a bit late here, so I may have missed something. For now, how
does the attached look to you?
|Next Message||Justin Pryzby||2022-09-07 08:57:29||Re: Different compression methods for FPI|
|Previous Message||Drouvot, Bertrand||2022-09-07 08:48:39||Re: ALTER TABLE uses a bistate but not for toast tables|