Re: plpgsql-trigger.html: Format TG_ variables as table (patch)

From: Christoph Berg <myon(at)debian(dot)org>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Date: 2022-09-01 13:07:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Re: Dagfinn Ilmari Mannsåker
> > Actually, just omitting the whole prefix works best.
> >
> > TG_WHEN (text)
> >
> > BEFORE, AFTER, or INSTEAD OF, depending on the trigger's definition.
> The attached patch does not reflect this, did you attach an old version?

Forgot to git commit before exporting the patch, thanks for catching!

> > I also shortened some "name of table" to just "table". Since the data
> > type is "name", it's clear what "table" means.
> I think it reads better with the definite article and initial capital,
> e.g. "The table that triggered ….".

Since that's not a complete sentence anyway, I think "The" isn't

> > - <term><varname>NEW</varname></term>
> > + <term><varname>NEW</varname> (record)</term>
> The type names should still be wrapped in <type>, like they were before.



Attachment Content-Type Size
0001-plpgsql-trigger.html-Use-more-concise-wording-for-TG.patch text/x-diff 6.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2022-09-01 13:27:24 Re: Reducing the chunk header sizes on all memory context types
Previous Message Tomas Vondra 2022-09-01 13:06:04 Re: POC: GROUP BY optimization