Re: doc: Clarify Routines and Extension Membership

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc: Clarify Routines and Extension Membership
Date: 2022-07-09 02:55:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jul 5, 2022 at 08:12:09PM -0400, Tom Lane wrote:
> "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> + A function that's marked as dependent on an extension is dropped when the
> + extension is dropped, even if cascade is not specified.
> + dependency checking in restrict mode <xref linkend="sql-dropextension"/>.
> + A function can depend upon multiple extensions, and will be dropped when
> + any one of those extensions is dropped.
> Third line here seems like a copy/paste mistake? Also I'd tend
> to mark up the keyword as <literal>CASCADE</literal>.
> + This form marks the procedure as dependent on the extension, or no longer
> + dependent on that extension if <literal>NO</literal> is specified.
> The/that inconsistency ... choose one. Or actually, the "an ... the"
> combination you used elsewhere doesn't grate on the ear either.
> + For each extension, refuse to drop anything if any objects (other than the
> + extensions listed) depend on it. However, its own member objects, and routines
> + that are explicitly dependent on this extension, are skipped.
> + This is the default.
> "skipped" seems like a horrible choice of word; it could easily be read as
> "they don't get dropped". I am not convinced that mentioning the member
> objects here is an improvement either. In the first sentence you are
> treating each extension as a monolithic object; why not in the second?

I created a modified patch based on this feedback; patch attached. I
rewrote the last change.

Bruce Momjian <bruce(at)momjian(dot)us>

Indecision is a decision. Inaction is an action. Mark Batterson

Attachment Content-Type Size
extension.diff text/x-diff 3.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-07-09 03:18:43 Re: doc: Clarify what "excluded" represents for INSERT ON CONFLICT
Previous Message Bruce Momjian 2022-07-09 02:42:58 Re: doc: Fix description of how the default user name is chosen