Re: Estimating HugePages Requirements?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Estimating HugePages Requirements?
Date: 2022-05-09 06:53:24
Message-ID: Yni6ZHkGotUU+RSf@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers

On Fri, May 06, 2022 at 10:13:18AM -0700, Nathan Bossart wrote:
> On Tue, Apr 26, 2022 at 10:34:06AM +0900, Michael Paquier wrote:
>> Yes, the redirection issue would apply to all the run-time GUCs.
>
> Should this be tracked as an open item for v15? There was another recent
> report about the extra log output [0].

That makes it for two complaints on two separate threads. So an open
item seems adapted to adjust this behavior.

I have looked at the patch posted at [1], and I don't quite understand
why you need the extra dance with log_min_messages. Why don't you
just set the GUC at the end of the code path in PostmasterMain() where
we print non-runtime-computed parameters? I am not really worrying
about users deciding to set log_min_messages to PANIC in
postgresql.conf when it comes to postgres -C, TBH, as they'd miss the
FATAL messages if the command is attempted on a server already
starting.

Per se the attached.

[1]: https://www.postgresql.org/message-id/20220328173503.GA137769@nathanxps13
--
Michael

Attachment Content-Type Size
v4-0001-Silence-extra-logging-with-postgres-C.patch text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message 类延良 2022-05-09 13:56:41 PostgreSQL14.2 can not start because of huge_page_size is equal to 1048576
Previous Message Nikhil Shetty 2022-05-08 06:42:06 Re: Postgres Stale Statistics

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-05-09 07:07:06 Re: proposal - psql - use pager for \watch command
Previous Message Amit Kapila 2022-05-09 06:47:15 Re: Logical replication timeout problem