| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas |
| Date: | 2022-04-01 05:38:51 |
| Message-ID: | YkaP64JvZTMgcHtq@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 31, 2022 at 12:09:35PM +0200, Matthias van de Meent wrote:
> PageInit MAXALIGNs the size of the special area that it receives as an
> argument; so any changes to the page header that would misalign the
> value would be AM-specific; in which case it is quite unlikely that
> this is the right accessor for your page's special area.
Right. I'd still be tempted to keep that per-AM rather than making
the checks deeper with one extra macro layer in the page header or
with a different macro that would depend on the opaque type, though.
Like in the attached, for example.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| opaque-macros.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-04-01 05:41:26 | Re: logical decoding and replication of sequences |
| Previous Message | Fabien COELHO | 2022-04-01 05:34:33 | Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors |