Re: Proposal: More structured logging

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: More structured logging
Date: 2022-04-07 06:44:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Jan 31, 2022 at 05:46:29PM -0500, Greg Stark wrote:
> It looks strange to me that the errorTag struct has a "const char
> *tagname" but a "char *tagvalue". I think this is a side effect of the
> code and not actually a sensible way to define the struct. Surely they
> should both be const?

This review has not been answered, and it was around for two months
now. I am marking this patch as returned with feedback.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-04-07 06:56:40 Re: Extensible Rmgr for Table AMs
Previous Message Michael Paquier 2022-04-07 06:36:19 Re: [PATCH] Add native windows on arm64 support