Re: Refactoring of compression options in pg_basebackup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Georgios Kokolatos <gkokolatos(at)pm(dot)me>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
Subject: Re: Refactoring of compression options in pg_basebackup
Date: 2022-01-19 04:27:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jan 18, 2022 at 10:04:56AM -0500, Robert Haas wrote:
> I think it could make sense for you implement
> --compress=METHOD[:LEVEL], keeping -z and -Z N as synonyms for
> --compress=gzip and --compress=gzip:N, and with --compress=N being
> interpreted as --compress=gzip:N. Then I'll generalize that to
> --compress=[{client|server}-]METHOD[:LEVEL] on the other thread. I
> think we should leave it where, if you don't say either client or
> server, you get client, because that's the historical behavior.
> If that doesn't work for you, please let me know what you would prefer.

WFM. Attached is a patch that extends --compress to handle a method
with an optional compression level. Some extra tests are added to
cover all that.


Attachment Content-Type Size
v5-0001-Rework-the-option-set-of-pg_basebackup.patch text/x-diff 12.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2022-01-19 04:31:59 Re: [PATCH] reduce page overlap of GiST indexes built using sorted method
Previous Message Andres Freund 2022-01-19 04:16:46 Re: Adding CI to our tree