| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Date: | 2022-01-18 02:20:16 |
| Message-ID: | YeYj4DU5qY/rtKXT@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 15, 2022 at 01:52:39PM +0800, Julien Rouhaud wrote:
> libpq environment variable PGHOST has a non-local server value: C:/Users/ContainerAdministrator/AppData/Local/Temp/FhBIlsw6SV
> Failure, exiting
> not ok 3 - run of pg_upgrade for new instance
There are two things here, as far as I understand:
1) This is a valid Windows path. So shouldn't we fix pg_upgrade's
server.c to be a bit more compliant with Windows paths? The code
accepts only paths beginning with '/' as local paths, so this breaks.
2) It looks safer in the long run to disable completely PGHOST and
PGHOSTADDR when running the pg_upgrade command in the test, and we'd
better not use Cluster::command_ok() or we would fall down to each
node's local environment. This could be done in the tests as of the
attached, I guess, and this would bypass the problem coming from 1).
The patch needed a refresh as --make-testtablespace-dir has been
removed as of d6d317d.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Switch-tests-of-pg_upgrade-to-use-TAP.patch | text/x-diff | 28.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-01-18 02:32:14 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2022-01-18 01:43:55 | Re: Null commitTS bug |