Re: pg_upgrade should truncate/remove its logs before running

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: 2022-01-24 01:59:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote:
> Neat idea. That would work fine for my case. So I am fine to stick
> with this suggestion.

I have been looking at this idea, and the result is quite nice, being
simpler than anything that has been proposed on this thread yet. We
get a simpler removal logic, and there is no need to perform any kind
of sanity checks with the output path provided as long as we generate
the paths and the dirs after adjust_data_dir().


Attachment Content-Type Size
v5-0001-pg_upgrade-write-log-files-and-dumps-in-subdir-fr.patch text/plain 15.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-01-24 02:10:07 Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Previous Message Tom Lane 2022-01-24 01:50:23 Re: Replace uses of deprecated Python module distutils.sysconfig