Re: Refactoring of compression options in pg_basebackup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: gkokolatos(at)pm(dot)me
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
Subject: Re: Refactoring of compression options in pg_basebackup
Date: 2022-01-05 08:00:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(Added Jeevan in CC, for awareness)

On Mon, Jan 03, 2022 at 03:35:57PM +0000, gkokolatos(at)pm(dot)me wrote:
> I propose to initialize streamer to NULL when declared at the top of
> CreateBackupStreamer().

Yes, that may be noisy. Done this way.

> You can see that after the check_pg_config() test, only 3 tests follow,
> namely:
> * $node->command_ok()
> * is(scalar(), ...)
> * is($gzip_is_valid, ...)

Indeed. The CF bot was complaining about that, actually.

Thinking more about this stuff, pg_basebackup --compress is an option
that exists already for a couple of years, and that's independent of
the backend-side compression that Robert and Jeevan are working on, so
I'd like to move on this code cleanup. We can always figure out the
LZ4 part for pg_basebackup after, if necessary.

Attached is an updated patch. The CF bot should improve with that.

Attachment Content-Type Size
v2-0001-Refactor-options-of-pg_basebackup-for-compression.patch text/x-diff 15.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-01-05 08:12:41 Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
Previous Message Simon Riggs 2022-01-05 07:53:05 Re: support for MERGE