Re: [PATCH] DROP tab completion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Ken Kato <katouknl(at)oss(dot)nttdata(dot)com>
Subject: Re: [PATCH] DROP tab completion
Date: 2021-12-01 02:07:23
Message-ID: YabY21Aa52x/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Nov 30, 2021 at 03:17:07PM +0000, Asif Rehman wrote:
> The patch applies cleanly and the functionality seems to work well. (master e7122548a3)
> The new status of this patch is: Ready for Committer

+ else if (Matches("DROP", "MATERIALIZED", "VIEW", MatchAny))
+ else if (Matches("DROP", "OWNED", "BY", MatchAny))
This stuff is gathered around line 3284 in tab-complete.c as of HEAD
at 538724f, but I think that you have done things right as there are
already sections for those commands and they have multiple keywords.
So, applied. Thanks!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-12-01 02:26:07 Re: row filtering for logical replication
Previous Message Greg Nancarrow 2021-12-01 01:57:17 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints