| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "liuhuailing(at)fujitsu(dot)com" <liuhuailing(at)fujitsu(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SI messages sent when excuting ROLLBACK PREPARED command |
| Date: | 2021-08-11 06:14:11 |
| Message-ID: | YRNqswLuKq67UbWO@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 03, 2021 at 09:29:48AM +0000, liuhuailing(at)fujitsu(dot)com wrote:
> There was a problem with the before patch when testing.
> So resubmit it.
FWIW, I see no problems with patch version 1 or 2, as long as you
apply patch version 1 with a command like patch -p2. One thing of
patch 2 is that git diff --check complains because of a whitespace.
Anyway, I also think that you are right here and that there is no need
to run this code path with ROLLBACK PREPARED. It is worth noting that
the point of Tom about local invalidation messages in PREPARE comes
from PostPrepare_Inval().
I would just tweak the comment block at the top of what's being
changed, as per the attached. Please let me know if there are any
objections.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| twophase-3.patch | text/x-diff | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-11 06:34:19 | Re: Unresolved repliaction hang and stop problem. |
| Previous Message | vignesh C | 2021-08-11 05:59:29 | Re: Added schema level support for publication. |