Re: [PATCH] Pull general SASL framework out of SCRAM

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "m(dot)kulagin(at)postgrespro(dot)ru" <m(dot)kulagin(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Date: 2021-07-14 01:42:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jul 13, 2021 at 10:41:01PM +0000, Jacob Champion wrote:
> Just to make sure -- do we want to export the fe-auth-sasl.h header as
> opposed to forward-declaring the pg_fe_sasl_mech struct?

Installing fe-auth-sasl.h has the advantage to make the internals of
the callbacks available to applications playing with the internals.
For SASL, it makes things easier to define new mechanisms out of

> Is the use
> case for libpq-int.h just "here, have at the internals, and if you
> break it then it's on you"?

Yes, it can be useful for applications willing to use the internals of
libpq, like in forks. There is no guarantee that this will not break
across major version upgrades, so that's up to the user to fix things
once they play with the internals.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2021-07-14 01:45:22 Re: Add proper planner support for ORDER BY / DISTINCT aggregates
Previous Message Kyotaro Horiguchi 2021-07-14 01:35:56 Re: Incorrect usage of strtol, atoi for non-numeric junk inputs