Re: Unused function parameter in get_qual_from_partbound()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unused function parameter in get_qual_from_partbound()
Date: 2021-06-09 02:50:10
Message-ID: YMAsYm7jH53qIdbu@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 09, 2021 at 12:28:48AM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> OK, Thanks for the explanation.
> Added to CF: https://commitfest.postgresql.org/33/3159/

At first glance, this looked to me like breaking something just for
sake of breaking it, but removing the rel argument could be helpful
to simplify any external code calling it as there would be no need for
this extra Relation. So that looks like a good idea, no need to rush
that into 14 though.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2021-06-09 02:51:29 Re: Adjust pg_regress output for new long test names
Previous Message Kyotaro Horiguchi 2021-06-09 02:47:21 Re: Duplicate history file?