Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Joel Jacobson <joel(at)compiler(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
Date: 2021-04-27 07:48:07
Message-ID: YIfBt7G7rKWyoAdQ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 27, 2021 at 07:16:25AM +0200, Joel Jacobson wrote:
> I've added a test at the end of event_trigger.sql,
> reusing the three event triggers already in existence,
> just before they are dropped.

Cool, thanks. I have been looking at it and I'd still like to
cross-check the output data of pg_get_object_address() to see if
pg_identify_object() remains consistent through it. See for example
the attached that uses a trick based on LATERAL, a bit different than
what's done in object_address.sql but that gives the same amount of
coverage (I could also use two ROW()s and an equality, but well..).
--
Michael

Attachment Content-Type Size
fix_event_trigger_pg_identify_object_as_address3.patch text/x-diff 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-04-27 08:16:55 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Peter Eisentraut 2021-04-27 07:47:42 Re: SQL-standard function body