Re: doc review for v14

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: doc review for v14
Date: 2021-03-01 04:11:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Feb 28, 2021 at 06:46:47PM -0600, Justin Pryzby wrote:
> It looks like you applied 0010...but I agree that it's not an improvement. It
> appears that's something I intended to go back and revisit myself.
> The rest of the patch looks right, to me.

Oops. This was not intended.

> I'm suggesting to either revert that part, or apply these more polished changes
> in 0002.

I would just group both things together. Monday helping, I can see
that the new wording is better on a couple of points after doing a
diff of wal.sgml with c82d59d6:
- "checksum protected" in the first sentence is weird, so I agree that
using "By default, data pages are not protected by checksums" is an
- "assigned" is indeed a bit strange, "includes" is an improvement,
and I would tend to not use a passive form here.
- "to recover from corrupt data" is redundant with "to recover data"
so the second one should be removed. My take is to use "page
corruptions" instead of "corrupt data", which should be corrupted data
to be grammatically correct.

This gives the attached, that has as result to not change the second
paragraph compared to the pre-c82d59d6 version of the area.

Attachment Content-Type Size
checksum-docs-v3.patch text/x-diff 1.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-03-01 04:33:55 Re: doc review for v14
Previous Message Masahiko Sawada 2021-03-01 04:07:45 Re: 64-bit XIDs in deleted nbtree pages