|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>|
|Cc:||Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, orlovmg(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org|
|Subject:||Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, Dec 13, 2022 at 09:32:19PM +0530, Bharath Rupireddy wrote:
> Okay, here's the v5 patch that I could come up with. It basically adds
> functions for dissecting WAL file names and computing offset from lsn.
I had a second look at that, and I still have mixed feelings about the
addition of the SQL function, no real objection about
I don't really think that we need a specific handling with a new
macro from xlog_internal.h that does its own parsing of the segment
number while XLogFromFileName() can do that based on the user input,
so I have simplified that.
A second thing is the TLI that had better be returned as int8 and not
int4 so as we don't have a negative number for a TLI higher than 2B in
a WAL segment name.
|Next Message||Alvaro Herrera||2022-12-19 08:07:57||Re: (non) translatable string splicing|
|Previous Message||Peter Smith||2022-12-19 07:56:42||Re: isolationtester - allow a session specific connection string|