Re: ALTER TABLE uses a bistate but not for toast tables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ALTER TABLE uses a bistate but not for toast tables
Date: 2022-10-12 06:52:56
Message-ID: Y0ZkSMJDavVEqn7S@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 07, 2022 at 10:48:39AM +0200, Drouvot, Bertrand wrote:
> +       if (bistate)
> +       {
> +               table_finish_bulk_insert(toastrel, options); // XXX
>
> I think it's too early, as it looks to me that at this stage we may have not
> finished the whole bulk insert yet.

Yeah, that feels fishy. Not sure what's the idea behind the XXX
comment, either. I have marked this patch as RwF, following the lack
of reply.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-10-12 06:53:05 Re: meson PGXS compatibility
Previous Message Michael Paquier 2022-10-12 06:40:21 Re: Tracking last scan time