|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>|
|Cc:||Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: fix archive module shutdown callback|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, Oct 18, 2022 at 02:38:07PM +0530, Bharath Rupireddy wrote:
> 2) Clarifies when the archive module shutdown callback gets called in
I have looked at that, and it was actually confusing as the callback
would also be called on reload if archive_library changes, but the
update somewhat outlines that this would happen only on postmaster
> 3) Defines a shutdown callback that just emits a log message in
> shell_archive.c and tests it.
The test had a few issues:
- No need to wait for postmaster.pid in the test, as pg_ctl does this
- The reload can be time-sensitive on slow machines, so I have added a
query run to make sure that the reload happens before stopping the
- slurp_file() was feeding on the full log file of standby2, but we
should load it from the log location before stopping the server, even
if log_min_messages was updated only at the end of the test.
And done, after tweaking a few more things.
|Next Message||vignesh C||2022-10-19 05:48:05||Re: Support logical replication of DDLs|
|Previous Message||Bharath Rupireddy||2022-10-19 04:51:12||Re: thinko in basic_archive.c|