| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: verbose mode for pg_input_error_message? |
| Date: | 2023-02-27 06:37:37 |
| Message-ID: | Y/xPsaofsKqwHNlG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 26, 2023 at 02:35:22PM +0900, Michael Paquier wrote:
> For the others, I would make the choice of expanding the calls of
> pg_input_error_info() rather than just showing row outputs, though I
> agree that this part is minor.
While bike-shedding all the regression tests, I have noticed that
float4-misrounded-input.out was missing a refresh (the query was
right, not the output). The rest was pretty much OK for me, still I
found all the errmsg aliases a bit out of context as the function is
now extended with more attributes, so I have painted a couple of
LATERALs over that.
Are you OK with the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-add-details-to-pg_input_error_message-and-rename-.patch | text/x-diff | 149.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-02-27 07:04:07 | RE: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Amit Kapila | 2023-02-27 06:33:48 | Re: Time delayed LR (WAS Re: logical replication restrictions) |