| From: | Ma Xueting <ma(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Report no unpinned buffers as insufficient resources |
| Date: | 2026-10-16 04:44:36 |
| Message-ID: | TYWP286MB2571E4ED9DE0E969AD113447EF9C2@TYWP286MB2571.JPNP286.PROD.OUTLOOK.COM |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
fujii-san,
Thank you for the suggestion.
Isn't it better to add "shared" to the error message to clarify
which buffers are involved, as the local-buffer message does?
I agree that explicitly mentioning shared buffers makes the error clearer.
I prefer the latter because "could not" describes the failed attempt
more clearly. If we adopt this, for consistency, it might be better
to also change the local-buffer message.
Agreed. I changed the messages in v2 to:
could not find an unpinned shared buffer
could not find an unpinned local buffer
I also updated the regression test expected output accordingly.
Best regards,
Xueting Ma
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Report-unpinned-buffer-errors-as-insufficient-res.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-10-16 05:03:57 | Re: Weird usages of sentinel_ok() |
| Previous Message | shihao zhong | 2026-10-16 04:31:43 | Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding |