| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | RE: Fix slotsync worker busy loop causing repeated log messages |
| Date: | 2026-04-10 10:28:29 |
| Message-ID: | TYRPR01MB14195D4C2B45E2DC986A3E7B294592@TYRPR01MB14195.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, April 10, 2026 5:53 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Apr 10, 2026 at 8:28 AM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
> >
> > Perhaps we could simply compare the slot's old and new LSN/xmin to
> > determine whether updated_xmin_or_lsn needs to be set.
> >
>
> The patch works for me. Can we change the comment to as follows: "It is
> possible that the slot's xmin or LSNs are not updated, when the synced slot
> has reached consistent snapshot state or cannot build the one at all."?
Changed as suggested.
Here are the patches for both HEAD and back branches.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-slotsync-worker-busy-loop-causing-repeated-lo.patch | application/octet-stream | 2.3 KB |
| v4_PG17_18-0001-Fix-slotsync-worker-busy-loop-causing-rep.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-04-10 10:28:59 | Re: Fix bug with accessing to temporary tables of other sessions |
| Previous Message | Amit Kapila | 2026-04-10 10:19:34 | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |