| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Greg Nancarrow' <gregn4422(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Optionally automatically disable logical replication subscriptions on error |
| Date: | 2021-11-30 12:04:14 |
| Message-ID: | TYCPR01MB83735AA021E0F614A3AB3221ED679@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, November 30, 2021 1:10 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> On Sat, Nov 27, 2021 at 1:36 AM osumi(dot)takamichi(at)fujitsu(dot)com
> <osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
> >
> > This v7 uses v26 of skip xid patch [1]
> This patch no longer applies on the latest source.
> Also, the patch is missing an update to doc/src/sgml/catalogs.sgml, for the
> new "subdisableonerr" column of pg_subscription.
Thanks for your review !
Fixed the documentation accordingly. Further,
this comment invoked some more refactoring of codes
since I wrote some internal codes related to
'disable_on_error' in an inconsistent order.
I fixed this by keeping patch's codes
after that of 'two_phase' subscription option as much as possible.
I also conducted both pgindent and pgperltidy.
Now, I'll share the v8 that uses PG
whose commit id is after 8d74fc9 (pg_stat_subscription_workers).
Best Regards,
Takamichi Osumi
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Optionally-disable-subscriptions-on-error.patch | application/octet-stream | 50.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2021-11-30 12:04:19 | Re: increase size of pg_commit_ts buffers |
| Previous Message | Amit Kapila | 2021-11-30 11:55:40 | Re: Non-superuser subscription owners |